Patch Set 2: Code-Review+1

The Intel i7-6700 seems to have the same IDs.

Unrelated, strange that inteltool uses different macro names.

    util/inteltool/inteltool.h:#define PCI_DEVICE_ID_INTEL_CORE_6TH_GEN_D   0x191f /* Skylake (Desktop) */

"0x191f" is deviceID of Host Bridge for Skylake desktop processors:

lspci:
00:00.0 Host bridge [0600]: Intel Corporation Sky Lake Host Bridge/DRAM Registers [8086:191f] (rev 07)

I think the title "Add a new desktop i5 CPU" is wrong.
It would be better to rename the commit title

View Change

1 comment:

• Commit Message:

  • Patch Set #2, Line 16: decktop

    desktop

    Done

To view, visit change 31601. To unsubscribe, or for help writing mail filters, visit settings.