Attention is currently required from: Nico Huber, Eugene Myers, Benjamin Doron, Paul Menzel, Angel Pons, Michael Niewöhner.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G
......................................................................
Patch Set 192: Code-Review+2
(1 comment)
File src/mainboard/acer/aspire_vn7_572g/mainboard.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/45a4a310_8d0f90fe
PS190, Line 34: 0x10251037
Fair point, but 0x1025 is Acer's ID? `lspci` outputs: "Subsystem: Acer Incorporated [ALI] Device [10 […]
Yes, AI stands for Acer International. So 1025 is their vendor ID which matches up.
Let's ignore the 1037 for now. It'd be good to get it into a #define at some point, but it's not critical.
Either way, let's do this change in a follow-on patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35523
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6340116abfeb2fbd280d143b74d323e4da3566f6
Gerrit-Change-Number: 35523
Gerrit-PatchSet: 192
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eugene Myers
cedarhouse1@comcast.net
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Eugene Myers
cedarhouse1@comcast.net
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Wed, 15 Dec 2021 16:55:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-MessageType: comment