Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34634 )
Change subject: drivers/vpd: add framework to search VPD in romstage ......................................................................
Patch Set 10:
(10 comments)
https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd.c File src/drivers/vpd/vpd.c:
https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd.c@107 PS10, Line 107: void why not just do 'const char *value' here so we don't need to re-cast later?
https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd.c@111 PS10, Line 111: vpd_find_romstage vpd_find
https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd.c@111 PS10, Line 111: return returning
https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd.c@119 PS10, Line 119: char const char
https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd_lib.c File src/drivers/vpd/vpd_lib.c:
https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd_lib.c@... PS10, Line 23: get_vpd_size can we just move this to vpd.c ?
https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd_premem... File src/drivers/vpd/vpd_premem.c:
https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd_premem... PS10, Line 35: no VPD at all? nothing to do then Return if no VPD at all.
https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd_premem... PS10, Line 36: (ro_vpd_size == 0) && (rw_vpd_size == 0) if (a == b && c == d)
(no need to quote since == has higher precedence.
https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd_premem... PS10, Line 49: if (ro_vpd_size != 0) { if (ro_vpd_size) {
https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd_premem... PS10, Line 57: sizeof(struct google_vpd_info) + : rdev_mmap_full(&vpd) not a big deal, but we usually write (ptr + number) instead of (number + ptr).
https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd_premem... PS10, Line 61: if (rw_vpd_size != 0) { if (rw_vpd_size) {