10 comments:
why not just do 'const char *value' here so we don't need to re-cast later?
Patch Set #10, Line 111: vpd_find_romstage
vpd_find
Patch Set #10, Line 111: return
returning
const char
File src/drivers/vpd/vpd_lib.c:
Patch Set #10, Line 23: get_vpd_size
can we just move this to vpd.c ?
File src/drivers/vpd/vpd_premem.c:
Patch Set #10, Line 35: no VPD at all? nothing to do then
Return if no VPD at all.
Patch Set #10, Line 36: (ro_vpd_size == 0) && (rw_vpd_size == 0)
if (a == b && c == d)
(no need to quote since == has higher precedence.
Patch Set #10, Line 49: if (ro_vpd_size != 0) {
if (ro_vpd_size) {
sizeof(struct google_vpd_info) +
rdev_mmap_full(&vpd)
not a big deal, but we usually write (ptr + number) instead of (number + ptr).
Patch Set #10, Line 61: if (rw_vpd_size != 0) {
if (rw_vpd_size) {
To view, visit change 34634. To unsubscribe, or for help writing mail filters, visit settings.