[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Select USE_LEGACY_8254_TIMER

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34709 )

Change subject: soc/intel/common: Select USE_LEGACY_8254_TIMER
......................................................................

Patch Set 2:

(1 comment)
> Patch Set 2:
>
> (2 comments)
>
> Why is only Intel affected?

USE_LEGACY_8254_TIMER is used on recent Intel platforms only.

https://review.coreboot.org/c/coreboot/+/34709/2/src/device/Kconfig 
File src/device/Kconfig:

https://review.coreboot.org/c/coreboot/+/34709/2/src/device/Kconfig@89 
PS2, Line 89: 	select USE_LEGACY_8254_TIMER if SOC_INTEL_COMMON_BLOCK
> What is the relation between VGA and 8254?

Option ROMs use the 8254 PIT instead of HPET, TSC or ACPI PM timer as you need to switch to protected mode to use those.
That isn't necessary when using the 8254 PIT.