Patch Set 2:
(2 comments)
Why is only Intel affected?
USE_LEGACY_8254_TIMER is used on recent Intel platforms only.
View Change
1 comment:
File src/device/Kconfig:
Patch Set #2, Line 89: select USE_LEGACY_8254_TIMER if SOC_INTEL_COMMON_BLOCK
What is the relation between VGA and 8254?
Option ROMs use the 8254 PIT instead of HPET, TSC or ACPI PM timer as you need to switch to protected mode to use those.
That isn't necessary when using the 8254 PIT.
To view, visit change 34709. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica0c20255f661dd61edc3a7d15646b7447c4658e
Gerrit-Change-Number: 34709
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Frans Hendriks <fhendriks@eltan.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 06 Aug 2019 10:43:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks <fhendriks@eltan.com>
Gerrit-MessageType: comment