Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34589 )
Change subject: AGESA: Fix discovery of IO APICs number ......................................................................
Patch Set 3:
(2 comments)
Tested with booting PC Engines APU2 on top of the postcar stage patches in the relation chain.
It neither improves boot time nor size. Just removes the hardcoded value which is not elegant by reading the value from silicon initialization code.
https://review.coreboot.org/c/coreboot/+/34589/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34589/2//COMMIT_MSG@9 PS2, Line 9: are
is
Done
https://review.coreboot.org/c/coreboot/+/34589/2//COMMIT_MSG@10 PS2, Line 10: parameter : block of an AGESA
What is that?
Rephrased it a little bit. In short, we interface AMD proprietary initialization blob called AGESA which holds the configuration values for the processor/SoC used in initialization process inside the blob.