Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48156 )
Change subject: arch/x86: Don't use .bss from car.ld if not running XIP ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review+1
(2 comments)
I'll hope to defer to someone using non-XIP and CAR for +2, however it looks OK to me now.
Oh, like the following patches, it's tested on Intel Apollolake. I'll add that into the commit message.
I meant that I'm confident enough that I can +2 the stack, if necessary, although non-XIP CAR doesn't apply to anything I've worked on. My preference is that a stakeholder also review these changes, but let me know if you can't get someone.