Patch Set 1:

Patch Set 1: Code-Review+1

(2 comments)

I'll hope to defer to someone using non-XIP and CAR for +2, however it looks OK to me now.

Oh, like the following patches, it's tested on Intel Apollolake. I'll add that into the commit message.

I meant that I'm confident enough that I can +2 the stack, if necessary, although non-XIP CAR doesn't apply to anything I've worked on. My preference is that a stakeholder also review these changes, but let me know if you can't get someone.

View Change

To view, visit change 48156. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6cf51f943dde5f642d75ba4c5d3be520dc56370a
Gerrit-Change-Number: 48156
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 01 Dec 2020 19:20:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment