Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39187 )
Change subject: mb/emulation/qemu-armv7: Fix board ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/39187/1/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-armv7/bootblock_asm.S:
https://review.coreboot.org/c/coreboot/+/39187/1/src/mainboard/emulation/qem... PS1, Line 37: msr cpsr_cxf, #0xdf
Would suggest transitioning to Thumb immediately, like the default code.
using common code instead
https://review.coreboot.org/c/coreboot/+/39187/1/src/mainboard/emulation/qem... PS1, Line 38:
You should call arm_init_caches somewhere. […]
using common code instead
https://review.coreboot.org/c/coreboot/+/39187/1/src/mainboard/emulation/qem... PS1, Line 55: beq relocated
This whole calling-_start-twice thing seems unnecessarily roundabout. […]
Fixed by jumping to "relocated" label after relocation was done instead of jumping to "_start".
https://review.coreboot.org/c/coreboot/+/39187/1/src/mainboard/emulation/qem... PS1, Line 59: stmia r0!, {r9-r10}
Why not just call memcpy()?
I tried that but it doesn't work. as it's only 3 instructions I didn't investigated further.
https://review.coreboot.org/c/coreboot/+/39187/1/src/mainboard/emulation/qem... PS1, Line 67: mov pc, lr
nit: odd way to spell "bl lr"?
no "bl" modifies the state while "mov pc" doesn't. If lr bit 0 isn't set it transistions to arm instruction mode.
https://review.coreboot.org/c/coreboot/+/39187/1/src/mainboard/emulation/qem... PS1, Line 94: bic sp, sp, #7 /* 8-byte alignment for ABI compliance */
cpu_info has been removed a long time ago. […]
no idea. used common code instead so this isn't applicable any more.