John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37665 )
Change subject: mb/google/drallion: Enable/disable GPIO clock gating
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37665/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37665/1//COMMIT_MSG@9
PS1, Line 9: CB:34180
Please add the git commit message summary in ().
Ack
https://review.coreboot.org/c/coreboot/+/37665/1//COMMIT_MSG@11
PS1, Line 11: to S0, the
Fits on the line above?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37665
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff121dfb0cd3d37a1da6ca31e1aff06ac33e037a
Gerrit-Change-Number: 37665
Gerrit-PatchSet: 2
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: JoeJ Chang
joej_chang@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 13 Dec 2019 02:37:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment