Thomas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48769 )
Change subject: mb/yanling: Add Yanling YL-KBR6L mainboard + doc ......................................................................
Patch Set 1:
(6 comments)
Patch Set 1:
Is it close enough to the Protectli FW6, so it could be added as a variant?
I assume it is close enough to be a variant of Protectli. My thinking was that if someone would have bought that Yanling computer she wouldn't look under Protectli for the mainboard source. And what name would we give that model?
Personally I think Protectli will get this and the faster model with i7-8550u cpu sooner or later.
While being in contact with Yanling because I couldn't get the 4G modem working with the stock firmware, they showed me screenshots of that it worked for them. The name of the Ubuntu workstation was 'ubuntu-FW6E' and the CPU was an i7-8550u. It certainly fits Protectlis naming. That would make this the FW6D model.
But adding it without the OK from Protectli or 3mdeb seems wrong to me.
https://review.coreboot.org/c/coreboot/+/48769/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48769/1//COMMIT_MSG@9 PS1, Line 9: Yanling YL-KBR6L
Do you have an URL for that? (I know, some folks do not like URLs in commit messages. […]
Hi Paul,
Thanks a lot for commenting.
Yes, I do have ULRs which are in the markdown document. I'm indeed not a big fan of URLs in commit messages, too. Since they are often longer then 75 chars.
Would it be enough to add a reference that the links can be found in the documentation?
https://review.coreboot.org/c/coreboot/+/48769/1//COMMIT_MSG@15 PS1, Line 15: SeaBIOS, Linux and FreeBSD
For the record, can you please also note down the used version of these?
I'll do that, yes.
https://review.coreboot.org/c/coreboot/+/48769/1//COMMIT_MSG@17 PS1, Line 17: VGA Option ROM
Extracting and adding vbt to the commit is also an option.
Most part of the commit message comes from the markdown document. And most of that is a one-to-one copy of the FW6 document.
That is one part of that. Maybe it's better if I remove all the parts which are already in the FW6 markdown and add only a reference to it?
To answer the question: I used 3mdebs VGA options rom, the download link which can be found in the excellent Protectli/3mdeb "coreboot-building-guide.pdf".
https://review.coreboot.org/c/coreboot/+/48769/1//COMMIT_MSG@18 PS1, Line 18: flashrom
What version?
I'll add the version.
https://review.coreboot.org/c/coreboot/+/48769/1//COMMIT_MSG@25 PS1, Line 25: Crucial CT2K32G4SFD8266
It is rather 2x 32GB by searching for it on google. […]
As Michal correctly said, it's 2x 32GB. I was avoiding to make the lines getting to long but I see it add confusion. I'll add the "2x32GB".
https://review.coreboot.org/c/coreboot/+/48769/1//COMMIT_MSG@32 PS1, Line 32: Removed
Present tense: Remove
Will be done.