build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 54: Verified+1
(64 comments)
File csb_patcher.sh:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/4cb0c4e1_122561b0 PS54, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/b9533de0_19fad39f PS54, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/460aacde_90c2f3a3 PS54, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/71096a7a_fedd278e PS54, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/2483171b_e9e6eb9f PS54, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/8393aa80_585561d5 PS54, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/a59e3a28_4d95a0b6 PS54, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/48036add_83250aa1 PS54, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/6c506364_818e925a PS54, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/3d2617e2_d2c6e0ba PS54, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/fe1dce92_8276828b PS54, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/e352dbf1_9b92f538 PS54, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/8c3d4dc6_760f4c9b PS54, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/f102ba2b_466ffbbc PS54, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/c339c346_64d6deb5 PS54, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/1ed62972_bbfea48f PS54, Line 315: floppy_verifier "fiwix" "9ec69b7b1a7554ff1aad784304c3926cad69e95abcac1f8a846a7f6251e25fd9" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/54e7326a_13df1574 PS54, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/ab9d6748_01dbc494 PS54, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/1fe04004_4fad1218 PS54, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/9c028c43_b696209b PS54, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/74eb6e97_ee5c3106 PS54, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/88772e25_2256c30f PS54, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/f18d16b6_008c575e PS54, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/21963e09_92ce36a8 PS54, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/b720382e_2307b338 PS54, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/38aeb496_12310d98 PS54, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/dfbabeec_d0ba9b28 PS54, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/651c177c_7bdbfecb PS54, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/a39a7fa3_1418fd4a PS54, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/c4ca903f_8492a788 PS54, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/b0bb0645_628263b9 PS54, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/d8b18946_b4df6265 PS54, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/0e61f00a_68a0dd59 PS54, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/5f845e6b_431b5751 PS54, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/c36d82e4_4e161ba1 PS54, Line 429: csb_patcher "atombios" "58748" "1" "d825cb8" "9dccb185ddd02ee9d6406bc157d2f5a0beace30d1efe122828f9ad51a18569ff" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/d2b8c479_7405336c PS54, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/15f62404_0c6ff60d PS54, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/e8a4a902_9a6f941d PS54, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/718d3223_975fb847 PS54, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/0caae45e_61d1232c PS54, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/b8afc25f_497787bd PS54, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/278dcba5_ea7e079b PS54, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/4abb18f3_00522ca2 PS54, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/85a28854_f15c883d PS54, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/fb6d3bb6_c92824c8 PS54, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/5193e748_ce550da0 PS54, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/99ba4b09_99882f56 PS54, Line 732: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/a9946300_ce7590d2 PS54, Line 734: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/eeb9ded8_30e51aa5 PS54, Line 749: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/49228bdf_158bd5f1 PS54, Line 751: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/536ec2bd_2ab2f729 PS54, Line 757: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/e89d3d50_70c8dc2d PS54, Line 773: csb_patcher "dgpu" "58745" "1" "d41dfa2" "107282101dbb021a5f24bc4bf6e0c0116f1e446b06ac8379cea6af2dae8cd398" "$1" "G505S " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/43f8e76f_2a0da49a PS54, Line 778: csb_patcher "atombios" "58748" "1" "d825cb8" "9dccb185ddd02ee9d6406bc157d2f5a0beace30d1efe122828f9ad51a18569ff" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/2423b55c_ba5d53b0 PS54, Line 783: csb_patcher "irq" "48427" "11" "8f2cdf1" "b82b7166377f81f16c8cebe54bb99b12efb12e3df6092a887773906196460340" "$1" "AMD good " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/4e0b5538_69d52b57 PS54, Line 788: csb_patcher "seabios" "32351" "15" "c4fc787" "b15163a492215c3155e3029415bf07a4514d6c02dd393ad09148d2d4adc17657" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/2f0ca667_95c8bcb7 PS54, Line 793: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/fc9353f8_a768aeb2 PS54, Line 798: csb_patcher "config.lenovo_g505s" "32352" "37" "a90256b" "ae7a0f2097ec71b215c421df695fc5adc021636240810b0b0a139ae41f975272" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/fec22641_aee6827c PS54, Line 803: csb_patcher "config.asus_am1i-a" "33800" "24" "7aa38bc" "f0522955c9394e58e9e10f1d7dabcc5f8c643e7af548cefe5bc4856cf754a9e9" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/10573a98_39311276 PS54, Line 808: csb_patcher "config.asus_a88xm-e" "39900" "11" "00eb676" "ab89fcd3c01e657f36c5845af0921d080209c06ce3077635bf53a56408ddb18d" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/7332ecbb_752563f2 PS54, Line 815: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/4f8e8d3c_639962dd PS54, Line 818: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/82189e94_aa9b029d PS54, Line 871: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/ece52cc7_f7fff011 PS54, Line 872: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/53f5a345_6fd0a64d PS54, Line 894: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters