[coreboot-gerrit] Change in coreboot[master]: cpu/x86: Introduce `CPU_X86_CACHE_HELPER`

[Angel Pons (Code Review)]

Attention is currently required from: Arthur Heymans, Kyösti Mälkki, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44226 )

Change subject: cpu/x86: Introduce `CPU_X86_CACHE_HELPER`
......................................................................

Patch Set 5:

(1 comment)

Patchset:

PS5:
> > had a look and in exit_car.S the cache gets enabled, so this would probably be ok to do, but i don't have any of the affected platforms to test. do you think that it would be a good intermediate solution to drop cpu/x86/cache and replace all x86_enable_cache calls with enable_cache calls? the only thing we would lose from that are the post code and the message on the console about this. i'd say that any of this should be done as a follow-up patch to avoid messy rebases
>
> It needs to be enabled on APs too. On LEGACY_SMP_INIT that is not done so it's needed in the CPU drivers.

Oh, good point. I completely forgot about APs. I'd still get rid of the `src/cpu/x86/cache` wrapper, though: the postcode gets outputted by every thread and there's the `printk()` concurrency locks to go through.