Attention is currently required from: Arthur Heymans, Kyösti Mälkki, Felix Held.
View Change
1 comment:
Patchset:
Patch Set #5:
had a look and in exit_car.S the cache gets enabled, so this would probably be ok to do, but i don't have any of the affected platforms to test. do you think that it would be a good intermediate solution to drop cpu/x86/cache and replace all x86_enable_cache calls with enable_cache calls? the only thing we would lose from that are the post code and the message on the console about this. i'd say that any of this should be done as a follow-up patch to avoid messy rebases
It needs to be enabled on APs too. On LEGACY_SMP_INIT that is not done so it's needed in the CPU drivers.
Oh, good point. I completely forgot about APs. I'd still get rid of the `src/cpu/x86/cache` wrapper, though: the postcode gets outputted by every thread and there's the `printk()` concurrency locks to go through.
To view, visit change 44226. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9b9b29a158c34a30480aaabf6d0b23819d28427
Gerrit-Change-Number: 44226
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov@gmail.com>
Gerrit-Reviewer: David Guckian <david.guckian@intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Arthur Heymans <arthur.heymans@9elements.com>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans@9elements.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Comment-Date: Mon, 25 Oct 2021 15:15:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur.heymans@9elements.com>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de>
Gerrit-MessageType: comment