Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35739 )
Change subject: soc/intel/common/block: Update microcode serialiced for HT threads ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35739/4/src/cpu/intel/common/hypert... File src/cpu/intel/common/hyperthreading.c:
https://review.coreboot.org/c/coreboot/+/35739/4/src/cpu/intel/common/hypert... PS4, Line 40: = 0; no need to initialize to 0 explicitly.
https://review.coreboot.org/c/coreboot/+/35739/4/src/cpu/intel/common/hypert... PS4, Line 46: 1; this value shouldn't be open coded. SPIN_LOCK_UNLOCKED definition should be used.
https://review.coreboot.org/c/coreboot/+/35739/4/src/cpu/intel/common/hypert... PS4, Line 53: /* Is Hyper-Threading supported */ : if (!(cpuid_edx(1) & CPUID_FEAURE_HTT)) : return; : This is duplicated below. Add a helper function?
https://review.coreboot.org/c/coreboot/+/35739/4/src/cpu/intel/common/hypert... PS4, Line 57: if (!initialized)
This would need to be checked inside the `init` lock. […]
Yes, this initialization should be done on BSP first instead of racing on the APs.
https://review.coreboot.org/c/coreboot/+/35739/4/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/mp_init.c:
https://review.coreboot.org/c/coreboot/+/35739/4/src/soc/intel/common/block/... PS4, Line 40: Tests For which parts? There are many different implementations.