5 comments:
File src/cpu/intel/common/hyperthreading.c:
no need to initialize to 0 explicitly.
this value shouldn't be open coded. SPIN_LOCK_UNLOCKED definition should be used.
/* Is Hyper-Threading supported */
if (!(cpuid_edx(1) & CPUID_FEAURE_HTT))
return;
This is duplicated below. Add a helper function?
Patch Set #4, Line 57: if (!initialized)
This would need to be checked inside the `init` lock. […]
Yes, this initialization should be done on BSP first instead of racing on the APs.
File src/soc/intel/common/block/cpu/mp_init.c:
Patch Set #4, Line 40: Tests
For which parts? There are many different implementations.
To view, visit change 35739. To unsubscribe, or for help writing mail filters, visit settings.