Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 34: Code-Review+1
Patch Set 34:
Patch Set 32: Code-Review+1
(2 comments)
Thanks for addressing the comments, Mike. I think this can go in after addressing the things in cmos.layout and after Balázs replies to the other comments :)
Thank you very much for your kind help, wish you a Happy New Year ;)
Happy New Year to you as well :)
Do you think romstage.c code could be carefully moved to bootblock.c ? I'm also thinking about how to replace inb(0xcd7) with something like pm_read8, just like outb is replaced with pm_write8. Last time I tried I couldn't do it, so at AM1I-A merged change CB:37829 I had to leave it as inb.
It would be nice. However, after such a change, I'd like to have this change boot-tested.