Patch Set 34:

Patch Set 32: Code-Review+1

(2 comments)

Thanks for addressing the comments, Mike. I think this can go in after addressing the things in cmos.layout and after Balázs replies to the other comments :)

Thank you very much for your kind help, wish you a Happy New Year ;)

Happy New Year to you as well :)


Do you think romstage.c code could be carefully moved to bootblock.c ? I'm also thinking about how to replace inb(0xcd7) with something like pm_read8, just like outb is replaced with pm_write8. Last time I tried I couldn't do it, so at AM1I-A merged change CB:37829 I had to leave it as inb.

It would be nice. However, after such a change, I'd like to have this change boot-tested.

Patch set 34:Code-Review +1

View Change

To view, visit change 30987. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60fa0636ba41f5f1a6a3faa2764bf2f0a968cf90
Gerrit-Change-Number: 30987
Gerrit-PatchSet: 34
Gerrit-Owner: Balázs Vinarz <vinibali1@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Balázs Vinarz <vinibali1@gmail.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 31 Dec 2019 17:38:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment