Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34766 )
Change subject: mb/google/hatch: Kohaku: Add digitizer enable GPIO to device tree
......................................................................
Patch Set 1:
(1 comment)
Why not squash this with the CL to enable stylus pen device?
https://review.coreboot.org/c/coreboot/+/34766/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34766/1/src/mainboard/google/hatch/...
PS1, Line 107: "1"
Didn't this create a problem? IIUC from the bug details, enable and reset need to go high at the same time. Shouldn't this delay be 0 in that case?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34766
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b0bd768cc8d9810fad6fd8a01f2a2635313008e
Gerrit-Change-Number: 34766
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 06 Aug 2019 22:54:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment