Change in coreboot[master]: mb/google/hatch: Kohaku: Add digitizer enable GPIO to device tree

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34766 )

Change subject: mb/google/hatch: Kohaku: Add digitizer enable GPIO to device tree
......................................................................

mb/google/hatch: Kohaku: Add digitizer enable GPIO to device tree

The enable GPIOs for several devices were shuffled around, and
this signal should now be used.

Change-Id: I9b0bd768cc8d9810fad6fd8a01f2a2635313008e
Signed-off-by: Tim Wawrzynczak 
---
M src/mainboard/google/hatch/variants/kohaku/overridetree.cb
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/34766/1

diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb
index 31f6af2..fe5cff3 100644
--- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb
@@ -103,6 +103,8 @@
    			register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)"
    			register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A10)"
    			register "generic.reset_delay_ms" = "1"
+				register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C15)"
+				register "generic.enable_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
    			register "hid_desc_reg_offset" = "0x1"
    			device i2c 0x09 on end

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34766 )

Change subject: mb/google/hatch: Kohaku: Add digitizer enable GPIO to device tree
......................................................................

Patch Set 1: Code-Review+1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34766 )

Change subject: mb/google/hatch: Kohaku: Add digitizer enable GPIO to device tree
......................................................................

Patch Set 1:

(1 comment)

Why not squash this with the CL to enable stylus pen device?

https://review.coreboot.org/c/coreboot/+/34766/1/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/34766/1/src/mainboard/google/hatch/... 
PS1, Line 107: "1"
Didn't this create a problem? IIUC from the bug details, enable and reset need to go high at the same time. Shouldn't this delay be 0 in that case?

[shkim (Code Review)]

shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34766 )

Change subject: mb/google/hatch: Kohaku: Add digitizer enable GPIO to device tree
......................................................................

Patch Set 1:
> Patch Set 1:
>
> (1 comment)
>
> Why not squash this with the CL to enable stylus pen device?

I think so - we can include this change into https://review.coreboot.org/c/coreboot/+/34581

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34766 )

Change subject: mb/google/hatch: Kohaku: Add digitizer enable GPIO to device tree
......................................................................

Abandoned