Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31948 )
Change subject: mb/asrock/h110m: Add PEG Gen3 support ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/31948/3/src/mainboard/asrock/h110m/romstage.... File src/mainboard/asrock/h110m/romstage.c:
https://review.coreboot.org/#/c/31948/3/src/mainboard/asrock/h110m/romstage.... PS3, Line 88: P that should be moved to soc/intel/... and check if the PCI device is enabled in devicetree.cb.
https://review.coreboot.org/#/c/31948/3/src/mainboard/asrock/h110m/romstage.... PS3, Line 89: mupd->FspmConfig.Peg0MaxLinkSpeed = 3; that could be read from devicetree.cb, too
https://review.coreboot.org/#/c/31948/3/src/mainboard/asrock/h110m/romstage.... PS3, Line 95: mupd->FspmTestConfig.Peg0Gen3EqPh2Enable = 1; that could be read from devicetree.cb, too