Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33178 )
Change subject: cpu/intel/haswell: Select TSC_MONOTONIC_TIMER
......................................................................
Patch Set 1:
Patch Set 1:
Please drop `src/cpu/intel/haswell/monotonic_timer.c` and update Makefile.
And ask Aaron why it was added? CB:3153
I can't recall entirely aside from there being a constant source. I think haswell has an invariant tsc? If so then it can be properly used. However, I'm not sure if were any lingering issues.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33178
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c5f90fa28452bd2bdf39691e75a30843b01df9b
Gerrit-Change-Number: 33178
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 03 Jun 2019 18:52:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment