Change in ...coreboot[master]: cpu/intel/haswell: Select TSC_MONOTONIC_TIMER
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33178 Change subject: cpu/intel/haswell: Select TSC_MONOTONIC_TIMER ...................................................................... cpu/intel/haswell: Select TSC_MONOTONIC_TIMER Also removes superfluous Kconfig options from some mainboard Kconfig's. Change-Id: I9c5f90fa28452bd2bdf39691e75a30843b01df9b Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> --- M src/cpu/intel/haswell/Kconfig M src/mainboard/asrock/h81m-hds/Kconfig M src/mainboard/supermicro/x10slm-f/Kconfig 3 files changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/33178/1 diff --git a/src/cpu/intel/haswell/Kconfig b/src/cpu/intel/haswell/Kconfig index 5936953..b3a596e 100644 --- a/src/cpu/intel/haswell/Kconfig +++ b/src/cpu/intel/haswell/Kconfig @@ -16,6 +16,7 @@ select SSE2 select UDELAY_TSC select TSC_CONSTANT_RATE + select TSC_MONOTONIC_TIMER select SMM_TSEG select SUPPORT_CPU_UCODE_IN_CBFS #select AP_IN_SIPI_WAIT diff --git a/src/mainboard/asrock/h81m-hds/Kconfig b/src/mainboard/asrock/h81m-hds/Kconfig index 928a010..6974cda 100644 --- a/src/mainboard/asrock/h81m-hds/Kconfig +++ b/src/mainboard/asrock/h81m-hds/Kconfig @@ -34,7 +34,6 @@ select SOUTHBRIDGE_INTEL_LYNXPOINT select SUPERIO_NUVOTON_NCT6776 select SUPERIO_NUVOTON_NCT6776_COM_A - select TSC_MONOTONIC_TIMER config CBFS_SIZE hex diff --git a/src/mainboard/supermicro/x10slm-f/Kconfig b/src/mainboard/supermicro/x10slm-f/Kconfig index 430bed3..3945c09 100644 --- a/src/mainboard/supermicro/x10slm-f/Kconfig +++ b/src/mainboard/supermicro/x10slm-f/Kconfig @@ -30,7 +30,6 @@ select SOUTHBRIDGE_INTEL_LYNXPOINT select SUPERIO_NUVOTON_NCT6776 select SUPERIO_NUVOTON_NCT6776_COM_A - select TSC_MONOTONIC_TIMER config CBFS_SIZE hex -- To view, visit https://review.coreboot.org/c/coreboot/+/33178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c5f90fa28452bd2bdf39691e75a30843b01df9b Gerrit-Change-Number: 33178 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-MessageType: newchange
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33178 ) Change subject: cpu/intel/haswell: Select TSC_MONOTONIC_TIMER ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/33178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c5f90fa28452bd2bdf39691e75a30843b01df9b Gerrit-Change-Number: 33178 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 03 Jun 2019 18:11:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33178 ) Change subject: cpu/intel/haswell: Select TSC_MONOTONIC_TIMER ...................................................................... Patch Set 1: Please drop `src/cpu/intel/haswell/monotonic_timer.c` and update Makefile. -- To view, visit https://review.coreboot.org/c/coreboot/+/33178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c5f90fa28452bd2bdf39691e75a30843b01df9b Gerrit-Change-Number: 33178 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-Comment-Date: Mon, 03 Jun 2019 18:28:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33178 ) Change subject: cpu/intel/haswell: Select TSC_MONOTONIC_TIMER ...................................................................... Patch Set 1:
Please drop `src/cpu/intel/haswell/monotonic_timer.c` and update Makefile.
And ask Aaron why it was added? CB:3153 -- To view, visit https://review.coreboot.org/c/coreboot/+/33178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c5f90fa28452bd2bdf39691e75a30843b01df9b Gerrit-Change-Number: 33178 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-Comment-Date: Mon, 03 Jun 2019 18:32:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33178 ) Change subject: cpu/intel/haswell: Select TSC_MONOTONIC_TIMER ...................................................................... Patch Set 1:
Patch Set 1:
Please drop `src/cpu/intel/haswell/monotonic_timer.c` and update Makefile.
And ask Aaron why it was added? CB:3153
I can't recall entirely aside from there being a constant source. I think haswell has an invariant tsc? If so then it can be properly used. However, I'm not sure if were any lingering issues. -- To view, visit https://review.coreboot.org/c/coreboot/+/33178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c5f90fa28452bd2bdf39691e75a30843b01df9b Gerrit-Change-Number: 33178 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-Comment-Date: Mon, 03 Jun 2019 18:52:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33178 ) Change subject: cpu/intel/haswell: Select TSC_MONOTONIC_TIMER ...................................................................... Abandoned I'll just link the monotonic_timer.c in early stages to fix flash console -- To view, visit https://review.coreboot.org/c/coreboot/+/33178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c5f90fa28452bd2bdf39691e75a30843b01df9b Gerrit-Change-Number: 33178 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-MessageType: abandon
participants (4)
-
Aaron Durbin (Code Review) -
Arthur Heymans (Code Review)
-
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)