Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33621 )
Change subject: soc/amd/stoneyridge: Add merlinfalcon configuration ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/33621/5/src/soc/amd/stoneyridge/Kco... File src/soc/amd/stoneyridge/Kconfig:
https://review.coreboot.org/c/coreboot/+/33621/5/src/soc/amd/stoneyridge/Kco... PS5, Line 33: bool
Add a prompt so this can be enabled & disabled in the menu.
Never did a prompt, so was not aware I could. Will investigate how.
https://review.coreboot.org/c/coreboot/+/33621/5/src/soc/amd/stoneyridge/Kco... PS5, Line 34: default n
Maybe add a help line saying that this option will be removed when the binaries are merged into the […]
Will do.
https://review.coreboot.org/c/coreboot/+/33621/5/src/soc/amd/stoneyridge/Kco... PS5, Line 153: if MERLINFALCON_BINARIES_PRESENT : config VGA_BIOS_FILE : string : default "3rdparty/blobs/soc/amd/merlinfalcon/VBIOS.bin" if SOC_AMD_MERLINFALCON : default "3rdparty/blobs/soc/amd/stoneyridge/VBIOS.bin" : endif # MERLINFALCON_BINARIES_PRESENT : : if !MERLINFALCON_BINARIES_PRESENT
The if clause isn't needed. Just add the one line: […]
Will do.
https://review.coreboot.org/c/coreboot/+/33621/5/src/soc/amd/stoneyridge/Kco... PS5, Line 210: MERLINFALCON_BINARIES_PRESENT
same comment as above.
Will do.
https://review.coreboot.org/c/coreboot/+/33621/5/src/soc/amd/stoneyridge/Kco... PS5, Line 347: <codename>
Stoneyridge?
Not sure, we are already at soc/stoneyridge. Maybe something like:
If your board is using a version of stoneyridge than it should select an appropriate fanless or fanned...