Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30767 )
Change subject: mb/asus/h61m-cs: Add ASUS H61M-CS ......................................................................
Patch Set 12: Code-Review+1
(3 comments)
The code looks good, and I'd like to give it a +2. Please document the USB issue in the commit message and address the small number of remaining comments. The USB issue can be fixed in a later commit.
For investigating the USB issue, I think the best start would be comparing logs, as Angel suggested.
Also, if some of the earlier patch sets didn't have the USB issue, it would be a good idea to try them again, making sure they have the same parent commit. If we know which change introduced the issue, it will be much easier to solve.
The only change I can see from the base patch set that possibly had an impact on the USB is that the super I/O GPIOs are no longer set. I do doubt that these would affect USB operation, though...
If you have any spare keyboards, I would suggest trying those too.
https://review.coreboot.org/#/c/30767/11/src/mainboard/asus/h61m-cs/Kconfig File src/mainboard/asus/h61m-cs/Kconfig:
https://review.coreboot.org/#/c/30767/11/src/mainboard/asus/h61m-cs/Kconfig@... PS11, Line 19: select INTEL_GMA_HAVE_VBT Why was this removed? Please add it back.
https://review.coreboot.org/#/c/30767/12/src/mainboard/asus/h61m-cs/devicetr... File src/mainboard/asus/h61m-cs/devicetree.cb:
https://review.coreboot.org/#/c/30767/12/src/mainboard/asus/h61m-cs/devicetr... PS12, Line 51: on end # PCIe x1 Slot 2 I assume this is no longer valid, as 1c.4 is the second slot?
https://review.coreboot.org/#/c/30767/12/src/mainboard/asus/h61m-cs/devicetr... PS12, Line 54: PCIe Port #5 Please update this comment to show it's a PCIe x1 slot.