[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/apollolake/Kconfig: Add CONSOLE_UART_BASE_ADDRESS

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33065 )

Change subject: soc/intel/apollolake/Kconfig: Add CONSOLE_UART_BASE_ADDRESS
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33065/2/src/soc/intel/apollolake/Kconfig 
File src/soc/intel/apollolake/Kconfig:

https://review.coreboot.org/#/c/33065/2/src/soc/intel/apollolake/Kconfig@367 
PS2, Line 367: 0xddffe000
> Use the define in iomap. […]

It wouldn't work as CONSOLE_UART_BASE_ADDRESS is used outside
of C (you can pass numbers from Kconfig to C but not the other
way around).

I have tried to clean the redundancy up in a different way,
get rid of the definitions in `iomap.h`: topic:lpss_console_cleanup