Attention is currently required from: Jamie Ryu, Tim Wawrzynczak, Sugnan Prabhu S, Meera Ravindranath.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46819 )
Change subject: soc/intel/common: Move reset request into intel_fw_update
......................................................................
Patch Set 15:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124285):
https://review.coreboot.org/c/coreboot/+/46819/comment/3b5c86ee_9eac76ca
PS15, Line 743: if (!cse_boot_to_rw(&cse_bp_info.bp_info)) {
suspect code indent for conditional statements (8, 8)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46819
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50da4206de05e552de68af7fa0afaef2dac33004
Gerrit-Change-Number: 46819
Gerrit-PatchSet: 15
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Comment-Date: Thu, 15 Jul 2021 08:01:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment