Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33387 )
Change subject: mainboard/emulation/qemu-aarch64: Add new board for ARMv8 ......................................................................
Patch Set 33:
(2 comments)
I think you should do the probe_ramsize() changes in a separate patch, it should be done outside the qemu-aarch64 mainboard and doesn't really belong together with this.
https://review.coreboot.org/c/coreboot/+/33387/29/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-aarch64/Kconfig:
https://review.coreboot.org/c/coreboot/+/33387/29/src/mainboard/emulation/qe... PS29, Line 48: config DRAM_SIZE_MB
probe_ramsize() is now commonized for qemu-riscv, qemu-armv7, and qemu-aarch64, but a Synchronous Ex […]
Yes, but this still needs to be integrated there, not hacked around it. You can just add an if (CONFIG(ARCH_ARM64)) in the probe_ramsize() code to special case the right parts (and again, you shouldn't just mask the exception, you should use the exception to figure out whether the address was accessible or not... so this essentially replaces most/all of probe_mb() from the generic implementation). You can also add a sort of arch_probe_memory() function with a __weak default implementation in src/lib and an override in src/arch/arm64 if you prefer that.
https://review.coreboot.org/c/coreboot/+/33387/33/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-aarch64/exception.c:
https://review.coreboot.org/c/coreboot/+/33387/33/src/mainboard/emulation/qe... PS33, Line 19: return EXC_RET_IGNORED; When you want it to skip the exception, it needs to return EXC_RET_HANDLED. Afterwards, when you no longer want it to skip (i.e. you want to get normal crash dumps again), it should return IGNORED. So this needs to depend on some global state that you change from the outside.