David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33660 )
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad
......................................................................
Patch Set 3:
(1 comment)
Thanks.
https://review.coreboot.org/#/c/33660/2/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/kindred/gpio.c:
https://review.coreboot.org/#/c/33660/2/src/mainboard/google/hatch/variants/...
PS2, Line 22: /* A21 : TRACKPAD_INT_ODL */
: PAD_CFG_GPI_APIC(GPP_A21, NONE, PLTRST, LEVEL, NONE),
: /* D21 : GPP_D21 ==> NC */
: PAD_NC(GPP_D21, NONE),
This will soon be done in baseboard/gpio.c: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33660
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I883ce2e50ca5c6bd2b1ca76cbe24177055cc5d60
Gerrit-Change-Number: 33660
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 27 Jun 2019 03:18:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Philip Chen
philipchen@google.com
Gerrit-MessageType: comment