Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41248 )
Change subject: soc/amd/common/block/spi: Add support for common SPI configuration
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41248/6/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/spi.h:
https://review.coreboot.org/c/coreboot/+/41248/6/src/soc/amd/common/block/in...
PS6, Line 59: #define SPI_FIFO_DEPTH (0xc7 - SPI_FIFO)
This is just a straight copy of what was present in the SoC header files. I agree it does look odd. […]
Addressed in 42076. Turned out to be correct, but said change improves the readability
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41248
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia4f231bab69e8450005dd6abe7a8e014d5eb7261
Gerrit-Change-Number: 41248
Gerrit-PatchSet: 7
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 04 Jun 2020 17:43:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment