Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45623 )
Change subject: ec/kontron: Fix control flow DEADCODE issue ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45623/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45623/7//COMMIT_MSG@11 PS7, Line 11: asserts check IMHO, this doesn't parse well. Also, the sentence I suggested hints at Coverity not being smart enough about code safety:
This change makes Coverity happy by using an assertion instead.
Let's not forget that, while tools can be helpful, they can also cause lots of pain. Have you ever hit your fingers while trying to hammer a nail? 😉