View Change
1 comment:
Commit Message:
Patch Set #7, Line 11: asserts check
IMHO, this doesn't parse well. Also, the sentence I suggested hints at Coverity not being smart enough about code safety:
This change makes Coverity happy by using an assertion instead.
Let's not forget that, while tools can be helpful, they can also cause lots of pain. Have you ever hit your fingers while trying to hammer a nail? 😉
To view, visit change 45623. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic002e708636961358969b2c1eaec0fee5bbcb73a
Gerrit-Change-Number: 45623
Gerrit-PatchSet: 7
Gerrit-Owner: John Zhao <john.zhao@intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Wed, 23 Sep 2020 11:41:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment