Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34763 )
Change subject: mb/google/hatch: Kohaku: Add touchscreen controller to device tree
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34763/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34763/1/src/mainboard/google/hatch/...
PS1, Line 90: register "reset_delay_ms" = "10"
Don't you also need the enable_gpio to ensure that power gets enabled for the device?
The only "enable" signal I see is TOUCHSCREEN_DIS_L which looks to be an active-low disable, but it's tied to PP3300_TSP_DX.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34763
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I759fb32f31c8eee0e6bd664c6a82308354ef5d08
Gerrit-Change-Number: 34763
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 06 Aug 2019 20:24:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment