Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39152 )
Change subject: soc/intel/{icl,jsl,tgl}: Enable PlatformDebugConsent by Kconfig
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39152/1/src/soc/intel/icelake/Kconf...
File src/soc/intel/icelake/Kconfig:
https://review.coreboot.org/c/coreboot/+/39152/1/src/soc/intel/icelake/Kconf...
PS1, Line 199:
i believe it has answer below as well. FSPMUPD.h […]
Indeed. It’s pretty inconvenient though. Some people will quit Kconfig, and configure everything again. If there is a way to put it in the description, I’d prefer that despite it means that the comment in the header is duplicated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39152
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39fe84025cb2bff186d61b2fcad531db52e2b440
Gerrit-Change-Number: 39152
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 27 Feb 2020 17:26:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment