19 Apr
2020
19 Apr
'20
4:17 p.m.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38203 )
Change subject: lenovo/g505s: enable the discrete VGA adapter ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38203/3/src/mainboard/lenovo/g505s/... File src/mainboard/lenovo/g505s/Kconfig:
https://review.coreboot.org/c/coreboot/+/38203/3/src/mainboard/lenovo/g505s/... PS3, Line 33: select PCIEXP_L1_SUB_STATE : select PCIEXP_ASPM : select PCIEXP_COMMON_CLOCK : select PCIEXP_CLK_PM
Done. […]
Yes, turned out discrete GPU works fine even without these PCIEXP options - so no need for a separate patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/38203
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebce6b53e196746968e10b5eb1be05a10a31b87e
Gerrit-Change-Number: 38203
Gerrit-PatchSet: 5
Gerrit-Owner: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 19 Apr 2020 16:17:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski michal.zygowski@3mdeb.com
Comment-In-Reply-To: Mike Banon mikebdp2@gmail.com
Gerrit-MessageType: comment