Attention is currently required from: Jamie Ryu, Rizwan Qureshi, Sridhar Siricilla. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44823 )
Change subject: soc/intel/common: [WIP]Support CSE FW update with compressed blobs ......................................................................
Patch Set 2:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/44823/comment/a53d7940_72e048d4 PS2, Line 8: Please elaborate.
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/44823/comment/2af243ca_7211a53c PS2, Line 27: #if CONFIG(SOC_INTEL_TIGERLAKE) : #define CSE_RW_BLOB_SIZE (4 * MiB) : #else : #define CSE_RW_BLOB_SIZE (2 * MiB) : #endif Shouldn’t that go into the devicetree or Kconfig?
https://review.coreboot.org/c/coreboot/+/44823/comment/e77ecc17_088b5178 PS2, Line 664: return false; Shouldn’t an error be printed?
https://review.coreboot.org/c/coreboot/+/44823/comment/b1cb9276_c043e143 PS2, Line 666: printk(BIOS_INFO, "cse_lite: blob size= %lu\n", cse_cbfs_rw_sz); Is that debug information?
https://review.coreboot.org/c/coreboot/+/44823/comment/de5969dc_0bb98f5f PS2, Line 666: %lu\ Please use correct length modifier for size_t.
https://review.coreboot.org/c/coreboot/+/44823/comment/78c65619_5ab7454d PS2, Line 701: No blank line necessary.