Attention is currently required from: Jamie Ryu, Rizwan Qureshi, Sridhar Siricilla.

View Change

6 comments:

• Commit Message:

  • Patch Set #2, Line 8:

    Please elaborate.

• File src/soc/intel/common/block/cse/cse_lite.c:

  • Patch Set #2, Line 27:

    #if CONFIG(SOC_INTEL_TIGERLAKE)
    #define CSE_RW_BLOB_SIZE	(4 * MiB)
    #else
    #define CSE_RW_BLOB_SIZE	(2 * MiB)
    #endif
    

    Shouldn’t that go into the devicetree or Kconfig?

  • Patch Set #2, Line 664: return false;

    Shouldn’t an error be printed?

  • Patch Set #2, Line 666: printk(BIOS_INFO, "cse_lite: blob size= %lu\n", cse_cbfs_rw_sz);

    Is that debug information?

  • Patch Set #2, Line 666: %lu\

    Please use correct length modifier for size_t.

  • Patch Set #2, Line 701:

    No blank line necessary.

To view, visit change 44823. To unsubscribe, or for help writing mail filters, visit settings.