Attention is currently required from: Jamie Ryu, Rizwan Qureshi, Sridhar Siricilla.
6 comments:
Commit Message:
Please elaborate.
File src/soc/intel/common/block/cse/cse_lite.c:
#if CONFIG(SOC_INTEL_TIGERLAKE)
#define CSE_RW_BLOB_SIZE (4 * MiB)
#else
#define CSE_RW_BLOB_SIZE (2 * MiB)
#endif
Shouldn’t that go into the devicetree or Kconfig?
Patch Set #2, Line 664: return false;
Shouldn’t an error be printed?
Patch Set #2, Line 666: printk(BIOS_INFO, "cse_lite: blob size= %lu\n", cse_cbfs_rw_sz);
Is that debug information?
Please use correct length modifier for size_t.
No blank line necessary.
To view, visit change 44823. To unsubscribe, or for help writing mail filters, visit settings.