Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46111 )
Change subject: trogdor: Modify DDR training to use mrc_cache ......................................................................
Patch Set 10: Code-Review+2
(3 comments)
Thanks, looks good!
https://review.coreboot.org/c/coreboot/+/46111/6/src/soc/qualcomm/common/qcl... File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/46111/6/src/soc/qualcomm/common/qcl... PS6, Line 142: (CONFIG(VBOOT) && get_recovery_mode_retrain_switch())) {
Ack. I've added the config and I'll ping Tom about how to force retraining from the EC.
I mean, generally you do it by pressing LShift+Esc+Refresh+Power. I'm just not sure if that combination is always enabled or if we need to turn on an extra config in the EC code.
https://review.coreboot.org/c/coreboot/+/46111/10/src/soc/qualcomm/common/qc... File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/46111/10/src/soc/qualcomm/common/qc... PS10, Line 142: if we're being forced to retrain. nit: this part doesn't really apply anymore.
https://review.coreboot.org/c/coreboot/+/46111/10/src/soc/qualcomm/common/qc... PS10, Line 145: data_size = REGION_SIZE(ddr_training); nit: this is kinda pointless here now