Thanks, looks good!
Patch set 10:Code-Review +2
3 comments:
File src/soc/qualcomm/common/qclib.c:
Patch Set #6, Line 142: (CONFIG(VBOOT) && get_recovery_mode_retrain_switch())) {
Ack. I've added the config and I'll ping Tom about how to force retraining from the EC.
I mean, generally you do it by pressing LShift+Esc+Refresh+Power. I'm just not sure if that combination is always enabled or if we need to turn on an extra config in the EC code.
File src/soc/qualcomm/common/qclib.c:
Patch Set #10, Line 142: if we're being forced to retrain.
nit: this part doesn't really apply anymore.
Patch Set #10, Line 145: data_size = REGION_SIZE(ddr_training);
nit: this is kinda pointless here now
To view, visit change 46111. To unsubscribe, or for help writing mail filters, visit settings.