Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45827 )
Change subject: soc/intel/braswell: Increase dcache size
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45827/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45827/1//COMMIT_MSG@9
PS1, Line 9: the
it?
https://review.coreboot.org/c/coreboot/+/45827/1/src/soc/intel/braswell/Kcon...
File src/soc/intel/braswell/Kconfig:
https://review.coreboot.org/c/coreboot/+/45827/1/src/soc/intel/braswell/Kcon...
PS1, Line 103: must add up to a power of 2
Given this comment, I believe you will have to bump it up to 0x8000.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45827
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1538d504ddad8654c79a789e58ffe6b11b5d544c
Gerrit-Change-Number: 45827
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 30 Sep 2020 06:39:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment