Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36457 )
Change subject: soc/intel/{cnl,icl}: Move globalnvs.asl into common/block/acpi
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
Could you also have a look at synchronizing GNVS between targets? I have the impression that a lot goes unused in for instance skylake.
Sure Arthur we can take a look into SKL code as well, but can we do that with little less priority (if needed i will raise a ticket in cb.org) compare to unblock TGL upstream code readiness work that we have in hand ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36457
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9fb12a75557bd7dc38f6d22ba2b32065d18b3ee
Gerrit-Change-Number: 36457
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 30 Oct 2019 10:58:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment