Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 85:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35523/81//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35523/81//COMMIT_MSG@14 PS81, Line 14: KBL VBT
Where is that gotten from?
I have a VBT with only timing parameters adjusted for the board here: https://github.com/benjamindoron/blobs/blob/master/mainboard/acer/aspire_vn7....
(Can document this if needed, but it was an interim solution to get the display working until I could properly port the display parameters from the vendor's VBT to an up-to-date version.)
The KBL VBT is located in 3rdparty/fsp/KabylakeFspBinPkg/SampleCode/Vbt/Vbt.bin
https://review.coreboot.org/c/coreboot/+/35523/81//COMMIT_MSG@18 PS81, Line 18: - (Perhaps fixed with I2C HID devices declared in devicetree)
If it refers to the item above, combine both items?
Not applicable? I've since declared the touchpad in devicetree and updated the commit message. The touchpad still doesn't wake the device, but that requires the wake GPIO declared too. I'm not sure it has one.
https://review.coreboot.org/c/coreboot/+/35523/81//COMMIT_MSG@26 PS81, Line 26: a customised KBL VBT
The vendor's VBT is version 200, which is too old? […]
They seem to have changed the size of some fields, leading to some truly impossible, out-of-range, values. When I tried it, if I didn't correct that, it would explain why it didn't work.