Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48244 )
Change subject: soc/intel/*/Kconfig: Enable x86_64 Kconfig option ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/48244/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48244/6//COMMIT_MSG@7 PS6, Line 7: Enable x86_64 Kconfig option `Enable` sounds like you're changing the default. How about `Allow building for x86_64` ?
https://review.coreboot.org/c/coreboot/+/48244/6//COMMIT_MSG@9 PS6, Line 9: Tested on Intel Skylake. Compiles and boots without issues. Please add a config to keep this known-working case build-tested.
https://review.coreboot.org/c/coreboot/+/48244/6//COMMIT_MSG@12 PS6, Line 12: Other platforms might not compile due to drivers not being ported : to x86_64 or might not boot due to a yet unsupported boot flow. Ideally, Jenkins should also build-test all boards with x86_64, like it does for CHROMEOS. This patch adds the option to many SoCs, but does not ensure that it at least gets build-tested.
IMHO, I'd prefer to only add the option to Skylake for now, along with a known-working configuration for Jenkins to build-test.
https://review.coreboot.org/c/coreboot/+/48244/6/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/48244/6/src/soc/intel/common/block/... PS6, Line 1: config EXP_ARCH_X86_64
Maybe SOC_ARCH_X86_64?
Wasn't there an equivalent option elsewhere?