4 comments:
Patch Set #6, Line 7: Enable x86_64 Kconfig option
`Enable` sounds like you're changing the default. How about `Allow building for x86_64` ?
Patch Set #6, Line 9: Tested on Intel Skylake. Compiles and boots without issues.
Please add a config to keep this known-working case build-tested.
Other platforms might not compile due to drivers not being ported
to x86_64 or might not boot due to a yet unsupported boot flow.
Ideally, Jenkins should also build-test all boards with x86_64, like it does for CHROMEOS. This patch adds the option to many SoCs, but does not ensure that it at least gets build-tested.
IMHO, I'd prefer to only add the option to Skylake for now, along with a known-working configuration for Jenkins to build-test.
File src/soc/intel/common/block/cpu/Kconfig:
Patch Set #6, Line 1: config EXP_ARCH_X86_64
Maybe SOC_ARCH_X86_64?
Wasn't there an equivalent option elsewhere?
To view, visit change 48244. To unsubscribe, or for help writing mail filters, visit settings.