Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36666 )
Change subject: Documentation: xx30 ThinkPads internal flashing ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Looks very good! I think I found one typo, though.
Also, optionally, it would be nice to break the lines. It seems convenient to have the viewer set the width, but not all tools allow it :-/ For instance in Gerrit on my mobile phone, I couldn't read the patch. It broke the lines at roughly 100 chars, with a fixed scaling... grml. 72 chars seems to be a good tradeoff for fixed width fonts.
https://review.coreboot.org/c/coreboot/+/36666/1/Documentation/mainboard/len... File Documentation/mainboard/lenovo/ivb_internal_flashing.md:
https://review.coreboot.org/c/coreboot/+/36666/1/Documentation/mainboard/len... PS1, Line 223: even ever?
https://review.coreboot.org/c/coreboot/+/36666/1/Documentation/mainboard/len... PS1, Line 274: Set BIOSWE: : ``` : sudo setpci -s 00:1f.0 dc.b=09 : ``` Flashrom should take care of this.