Looks very good! I think I found one typo, though.

Also, optionally, it would be nice to break the lines. It seems
convenient to have the viewer set the width, but not all tools
allow it :-/ For instance in Gerrit on my mobile phone, I couldn't
read the patch. It broke the lines at roughly 100 chars, with a
fixed scaling... grml. 72 chars seems to be a good tradeoff for
fixed width fonts.

Patch set 1:Code-Review +1

View Change

2 comments:

To view, visit change 36666. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d8551910c31fd2e6ff728e17dafaea45970166b
Gerrit-Change-Number: 36666
Gerrit-PatchSet: 1
Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Peter Lemenkov <lemenkov@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 04 Feb 2020 18:05:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment