Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32862 )
Change subject: device_tree: Add version checks ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/32862/5/src/include/device_tree.h File src/include/device_tree.h:
https://review.coreboot.org/#/c/32862/5/src/include/device_tree.h@36 PS5, Line 36: last_comp_version
isn't the old name better?
This is how it's called in the official device tree specification (https://www.devicetree.org/downloads/devicetree-specification-v0.1-20160524.... page 39).
https://review.coreboot.org/#/c/32862/5/src/lib/device_tree.c File src/lib/device_tree.c:
https://review.coreboot.org/#/c/32862/5/src/lib/device_tree.c@237 PS5, Line 237: printk(BIOS_DEBUG, : "NOTE: FDT version %u too new, should add support!\n", : version);
so we're not failing or skip?
This case means last_comp_version is <= our version but version is >, so the device tree is still compatible with us, it's just a hint to tell us that we might want to update our code (I think you asked me to add this line on the depthcharge review, didn't you?).