View Change

2 comments:

• File src/include/device_tree.h:

  • Patch Set #5, Line 36: last_comp_version

    isn't the old name better?

    This is how it's called in the official device tree specification (https://www.devicetree.org/downloads/devicetree-specification-v0.1-20160524.pdf page 39).

• File src/lib/device_tree.c:

  • Patch Set #5, Line 237:

    printk(BIOS_DEBUG,
    		       "NOTE: FDT version %u too new, should add support!\n",
    		       version);
    

    so we're not failing or skip?

    This case means last_comp_version is <= our version but version is >, so the device tree is still compatible with us, it's just a hint to tell us that we might want to update our code (I think you asked me to add this line on the depthcharge review, didn't you?).

To view, visit change 32862. To unsubscribe, or for help writing mail filters, visit settings.