Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42454 )
Change subject: cpu/x86/lapic_def.h: Drop unused macros ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
https://review.coreboot.org/c/coreboot/+/42454/1/src/include/cpu/x86/lapic_d... File src/include/cpu/x86/lapic_def.h:
https://review.coreboot.org/c/coreboot/+/42454/1/src/include/cpu/x86/lapic_d... PS1, Line 60: #define LAPIC_TIMER_BASE_CLKIN 0x0 : #define LAPIC_TIMER_BASE_TMBASE 0x1 : #define LAPIC_TIMER_BASE_DIV 0x2 after removing the macros these values are meant to be used with, these values become just wrong. adding the shift here would make them correct again
https://review.coreboot.org/c/coreboot/+/42454/1/src/include/cpu/x86/lapic_d... PS1, Line 74: #define LAPIC_MODE_FIXED 0x0 : #define LAPIC_MODE_NMI 0x4 : #define LAPIC_MODE_EXINT 0x7 if you delete the macro using these values, you should also delete these values to avoid even more confusion. the defines that shift things to the right bit positions are above